Skip to content

Conversation

@zephyrbot
Copy link

@zephyrbot zephyrbot commented Dec 6, 2024

Backport c12030a from #82448.

Fixes #82437

The FlexSPI NOR driver should verify all 3 bytes of the JEDEC ID match
the expected value before attempting to use a custom LUT table with a
flash chip. This reduces the odds that an incompatible LUT will be used
with a flash chip, as some flash chips may share the same first byte of
their device ID but not be compatible with the custom LUT table.

Signed-off-by: Daniel DeGrasse <[email protected]>
(cherry picked from commit c12030a)
@zephyrbot zephyrbot added the Backport Backport PR and backport failure issues label Dec 6, 2024
@zephyrbot zephyrbot added platform: NXP Drivers NXP Semiconductors, drivers area: Flash labels Dec 6, 2024
@de-nordic de-nordic modified the milestones: v4.3.0, v4.1.0 Dec 17, 2024
@dkalowsk
Copy link
Contributor

@de-nordic this is a backport for 4.0 branch, but you've added a milestone of 4.1 and 4.3 (which I didn't even know we had yet). Are you sure these are the right milestones?

@de-nordic de-nordic removed this from the v4.1.0 milestone Jan 2, 2025
@de-nordic
Copy link
Contributor

@de-nordic this is a backport for 4.0 branch, but you've added a milestone of 4.1 and 4.3 (which I didn't even know we had yet). Are you sure these are the right milestones?

No I am not. That was incorrect milestone. I have actually added 4.3, because it is hard to click, while trying to set 4.1 - which was not correct.

@dkalowsk dkalowsk added this to the v4.0.1 milestone Jan 6, 2025
@dkalowsk
Copy link
Contributor

dkalowsk commented Jan 6, 2025

@de-nordic this is a backport for 4.0 branch, but you've added a milestone of 4.1 and 4.3 (which I didn't even know we had yet). Are you sure these are the right milestones?

No I am not. That was incorrect milestone. I have actually added 4.3, because it is hard to click, while trying to set 4.1 - which was not correct.

I thought as much but wanted to verify before moving forward. Thanks for the clarification! And yeah the Milestone UI is... not great.

@dkalowsk dkalowsk merged commit c861286 into v4.0-branch Jan 6, 2025
30 checks passed
@dkalowsk dkalowsk deleted the backport-82448-to-v4.0-branch branch January 6, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: Flash Backport Backport PR and backport failure issues platform: NXP Drivers NXP Semiconductors, drivers

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants